A change was made recently to spree for multi-currency. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The copy_price method used to return the price: spree/spree@58ec5cd#L12L27 but it no longer does, so we must not rely on its return value in our 'overridden' method. fixes logic for changing price after quantity changes
jsqu99
added a commit
that referenced
this pull request
Jun 6, 2013
The copy_price method used to return the price: spree/spree@58ec5cd#L12L27 but it no longer does, so we must not rely on its return value in our 'overridden' method. fixes logic for changing price after quantity changes Related to #40 Conflicts: app/models/spree/line_item_decorator.rb
jsqu99
added a commit
that referenced
this pull request
Jun 6, 2013
jsqu99
added a commit
that referenced
this pull request
Jun 6, 2013
The copy_price method used to return the price: spree/spree@58ec5cd#L12L27 but it no longer does, so we must not rely on its return value in our 'overridden' method. fixes logic for changing price after quantity changes Related to #40
jsqu99
added a commit
that referenced
this pull request
Jun 6, 2013
jsqu99
added a commit
that referenced
this pull request
Jun 6, 2013
The copy_price method used to return the price: spree/spree@58ec5cd#L12L27 but it no longer does, so we must not rely on its return value in our 'overridden' method. fixes logic for changing price after quantity changes Related to #40 Conflicts: app/models/spree/line_item_decorator.rb
|
Added to master, 2-0-stable and 1-3-stable. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The copy_price method used to return the price:
spree/spree@58ec5cd#L12L27
but it no longer does, so we must not rely on its return value in our 'overridden' method.
The tests are currently failing (before my request), but this fixes several.
I'm requesting a thorough review of my changes just to be safe as I'm not sure that some of the existing code was necessary/correct.
Also, please cherry pick to master as well