[SD-1447] Checkout unshippable items endpoint #11323
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes preview: Legend: |
szymoniwacz
force-pushed
the
feature/SD-1447-api-v2-storefront-unshippable-items
branch
from
434a0fd
to
e633e0f
Compare
|
What's left in this PR is adding API calls documentation. |
damianlegawiec
requested changes
Sep 16, 2021
Comment on lines
33
to
37
| end | ||
|
|
||
| def unshippable_items(order:) |
There was a problem hiding this comment.
Suggested change
| end | |
| def unshippable_items(order:) | |
| end | |
| protected | |
| def unshippable_items(order:) |
| end | ||
|
|
||
| def unshippable_items(order:) | ||
| shipping_address_zone_id = Spree::Zone.match(order.shipping_address)&.id |
There was a problem hiding this comment.
Suggested change
| shipping_address_zone_id = Spree::Zone.match(order.shipping_address)&.id | |
| shipping_address_zone_id = Spree::Zone.match(order.shipping_address)&.id |
this uses all zones, and not the order.store.checkout_zone
szymoniwacz
force-pushed
the
feature/SD-1447-api-v2-storefront-unshippable-items
branch
from
4241d29
to
958453a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.