Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#9c2307ae was omitted in 3.1-stable! #7693

Closed
gcauchon opened this issue Nov 19, 2016 · 2 comments
Closed

#9c2307ae was omitted in 3.1-stable! #7693

gcauchon opened this issue Nov 19, 2016 · 2 comments

Comments

@gcauchon
Copy link

We've been working on a ecomm website for some weeks now. It came too our attention the shipping related values have been creeping slowly each time changes were made to a Product when the Admin was used in locale other than :en. Another clue was those same fields were displayed in a . decimal format instead of the locale's ,!

spree_product_form

We found the problem to be caused by the missing number_with_precision in admin/products/_form.html.erb#L110-L138...

The fix already exists in master...

However, we soon after realized the issue have been fixed in master a long time ago, but the fix #9c2307ae was never merged to the current stable branch...
@damianlegawiec
Copy link
Member

damianlegawiec commented Nov 20, 2016 •
edited

@gcauchon we'll backport this fix in 3.1.3 next week :)

BTW. master will become 3.2.0 in coming weeks

@damianlegawiec damianlegawiec mentioned this issue Dec 1, 2016
Merged
@damianlegawiec
Copy link
Member

@gcauchon backported to 3-1-stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@damianlegawiec @gcauchon