Locks devise into an old version

[magnusvk]

spree_auth_devise currently locks us into the 3.0 major release of Devise, even though Devise is now up to 3.2. Again, don't have the time now to fix that and work towards an upgrade, but we do want to do that eventually here at Bonobos. I just wanted to open an issue as to not forget.

[radar]

@magnusvk This is partly due to Devise wanting a secret_key in applications in Devise 3.1+. I have not yet worked out a way to make it happy, but it might be possible if we added an installer to spree_auth_devise.

[radar]

Oh, and they've deprecated TokenAuthenticatable, which we have been using for API authentication too. That itself is an easy fix.

[radar]

I have done some work on my fork of this extension, on the 2-1-stable and master branches to upgrade the Devise version to 3.2.2. I am not going to push this to spree/spree_auth_devise until next week because it's very late in my work day on a Friday.

If you could, please kick the tyres on my 2-1-stable and master branches and let me know how it goes. You will need to follow the instructions to add Devise.secret_token, or just run this command which will do that part automatically:

rails g spree:auth:install

[radar]

@magnusvk I can confirm the tests are working on 2-1-stable and master (at least on my machine), so that's pretty good. Still, wouldn't hurt if you found some time to try it out today. Don't sweat it if you don't get time.

[radar]

These changes are now on the spree/spree_auth_devise repo. Thanks @magnusvk :)

[magnusvk]

No thanks deserved on my end! Thank YOU on the quick turn-around here.

• Magnus

Sent from my iPhone

On Dec 16, 2013, at 6:55 PM, Ryan Bigg notifications@github.com wrote:

These changes are now on the spree/spree_auth_devise repo. Thanks @magnusvk :)

—
Reply to this email directly or view it on GitHub.