implement sync producing with a strategy different from the default one

[dams]

when you have defined a producer in the config, but you want to produce_sync to it with a different strategy (say you tried with md5 but it failed and you want to try it with :random)

[objectuser]

@dams Would this signature also work?

def produce_sync(topic, message_list, strategy) when is_list(message_list) ...

Seems like there's a lot of overloaded names in there, but I don't know what the Elixir best practice is here. Maybe a keyword list?

[dams]

no, there is already:

def produce_sync(topic, partition, message_list) when is_list(message_list)

I have to say that the public API of this file is ... messy :) Or at leat, not the style I like the best

[objectuser]

Those two wouldn't conflict would they? The list is the third parameter vs. the second.

But I agree, I find it confusing. I'm thinking an options list would be better.

[objectuser]

What about something like this:

def produce(topic, message_list, opts \\ [])

Then if a single message was being produced, it would be:

Kaffe.Producer.produce(topic, [{key, value}], partition_strategy: :md5)

It looks simple from the signature perspective, but I'm not sure how complicated it would be to implement.

[dams]

Oh yes, you're right, technically it doesn't conflict, but it'd be soooo confusing :)

In my humble opinion you should keep it simple indeed, maybe even simler than what you propose. Only support message_list, and have "sync_mode" or "strategy" be specified via options

def produce(topic, messages, opt \\ [])