PermalinkGenerator: Keep title_path as-is with preserve_title_path #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures e.g. dots are kept (instead of replaced with dashes) and case is preserved.
| @@ -226,7 +226,7 @@ private function getTitleSlugified(ItemInterface $item) | |||
| $preservePathTitle = $this->getPreservePathTitleAttribute($item); | |||
|
|
|||
| if ($preservePathTitle === true && isset($attributes['title_path']) === true) { | |||
| return (new StringWrapper($attributes['title_path']))->slug(); | |||
| return $attributes['title_path']; | |||
There was a problem hiding this comment.
In this case, if you are using certain characters such as spaces, you'll get a bad permalink but I understand that if you turn on preserve_title_path feature is because you want to preserver the title from the path and it is under your risk
There was a problem hiding this comment.
Right, well then maybe use urlencode() instead of slug(), so e.g.
spaces are turned to %20 and such, to try and ensure good/valid URLs,
but nothing else.
|
I'll update the documentation of this attribute in http://spress.yosymfony.com/docs/writing-posts/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures e.g. dots are kept (instead of replaced with dashes) and case is
preserved.