Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Temporarily overriding google-cloud-core version #2149

Merged
merged 1 commit into from Jan 29, 2020
Merged

Temporarily overriding google-cloud-core version #2149

merged 1 commit into from Jan 29, 2020

Conversation

suztomo
Copy link
Contributor

@suztomo suztomo commented Jan 29, 2020

Fixes #2142. Temporary solution until libraries-bom contains google-cloud-core 1.92.2.

@suztomo suztomo requested a review from dmitry-s January 29, 2020 21:54
@suztomo
Copy link
Contributor Author

suztomo commented Jan 29, 2020

mvn clean install -Dit.spanner=true passed in my local gLinux.

@suztomo
Copy link
Contributor Author

suztomo commented Jan 29, 2020

@dmitry-s While I was trying to run the whole integration test, it seems that I still need to have access to storage buckets (and objects):

[INFO] Running org.springframework.cloud.gcp.storage.it.GoogleStorageIntegrationTests
Jan 29, 2020 5:00:36 PM com.google.auth.oauth2.DefaultCredentialsProvider warnAboutProblematicCredentials
WARNING: Your application has authenticated using end user credentials from Google Cloud SDK. We recommend that most server applications use service accounts instead. If your application continues to use end user credentials from Cloud SDK, you might receive a "quota exceeded" or "API not enabled" error. For more information about service accounts, see https://cloud.google.com/docs/authentication/.
[ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 1.499 s <<< FAILURE! - in org.springframework.cloud.gcp.storage.it.GoogleStorageIntegrationTests
[ERROR] createWithContent  Time elapsed: 1.131 s  <<< ERROR!
com.google.cloud.storage.StorageException: suztomo@google.com does not have storage.objects.get access to integration-spring-cloud-gcp/integration-test.
	at org.springframework.cloud.gcp.storage.it.GoogleStorageIntegrationTests.deleteResource(GoogleStorageIntegrationTests.java:89)
	at org.springframework.cloud.gcp.storage.it.GoogleStorageIntegrationTests.setUp(GoogleStorageIntegrationTests.java:96)

As .travis.yml has the command to run integration test, can I invoke that on Travis? (If it works, this doesn't require me to setup GCP environment)

@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #2149 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2149   +/-   ##
=========================================
  Coverage     72.59%   72.59%           
  Complexity     1911     1911           
=========================================
  Files           245      245           
  Lines          7038     7038           
  Branches        725      725           
=========================================
  Hits           5109     5109           
  Misses         1591     1591           
  Partials        338      338
Flag Coverage Δ Complexity Δ
#integration ? ?
#unittests 72.59% <ø> (ø) 1911 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ccadab...f60eeee. Read the comment docs.

@dmitry-s
Copy link
Contributor

@suztomo just to clarify, what exactly are you trying to test?

cc/ @meltsufin

@meltsufin meltsufin merged commit c290b9f into spring-attic:master Jan 29, 2020
@suztomo
Copy link
Contributor Author

suztomo commented Jan 29, 2020

I want to confirm ”this dependency upgrade won’t break existing integration tests” by myself.

@meltsufin
Copy link
Contributor

@suztomo
Copy link
Contributor Author

suztomo commented Jan 30, 2020

@meltsufin Thank you for confirmation.

@suztomo suztomo deleted the libraries-bom branch January 30, 2020 15:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants