This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Fix reading log format #2377
Merged
Fix reading log format #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzou
previously approved these changes
May 19, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #2377 +/- ##
=========================================
Coverage 73.89% 73.89%
Complexity 2096 2096
=========================================
Files 260 260
Lines 7576 7576
Branches 785 785
=========================================
Hits 5598 5598
Misses 1616 1616
Partials 362 362
Continue to review full report at Codecov.
|
dzou
approved these changes
May 19, 2020
dmitry-s
approved these changes
May 19, 2020
meltsufin
approved these changes
May 19, 2020
elefeint
added a commit
that referenced
this pull request
May 19, 2020
Same fix as #2377, but for logging sample test. The logging format switched from text to json in com.google.cloud.google-cloud-logging-logback:v0.117.0 (googleapis/java-logging-logback#43). This PR fixes the trace integration test by switching from reading textPayload to jsonPayload for verification of trace correlation to log.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logging format switched from text to json in
com.google.cloud.google-cloud-logging-logback:v0.117.0(googleapis/java-logging-logback#43).This PR fixes the trace integration test by switching from reading
textPayloadtojsonPayloadfor verification of trace correlation to log.