Improves comparison of strings in DefaultRedirectResolver

Fixes gh-1745
spring-attic · Apr 8, 2020 · 9c09209 · 9c09209
1 parent d93722a
commit 9c09209
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/...n/java/org/springframework/security/oauth2/provider/endpoint/DefaultRedirectResolver.java b/...n/java/org/springframework/security/oauth2/provider/endpoint/DefaultRedirectResolver.java
@@ -175,12 +175,10 @@ private boolean matchQueryParams(MultiValueMap<String, String> registeredRedirec
 	 * @return true if strings are equal, false otherwise
 	 */
 	private boolean isEqual(String str1, String str2) {
-		if (StringUtils.isEmpty(str1) && StringUtils.isEmpty(str2)) {
-			return true;
-		} else if (!StringUtils.isEmpty(str1)) {
-			return str1.equals(str2);
+		if (StringUtils.isEmpty(str1)) {
+			return StringUtils.isEmpty(str2);
 		} else {
-			return false;
+			return str1.equals(str2);
 		}
 	}