-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding correlationId from 4financeIT micro-infra-spring #1
Adding correlationId from 4financeIT micro-infra-spring #1
Conversation
I can work on guava for zipkin since it's part of their api. I'd put your correlation stuff in another module, maybe |
I had to ignore some I've extracted I don't know if the property names are ok - so please check them out :) |
f4c5e4a
to
32d034e
Compare
@marcingrzejszczak if you rebase against master you should be able to un-comment the zipkin code and it should build again |
32d034e
to
ba03b82
Compare
Done :) Unfortunately after uncommenting the lines the code doesn't compile - maybe I've done sth wrong :/ |
b274890
to
c0fc585
Compare
Ok Fixed that. BTW I can't locally build this. ALl the time I have issues with Guava. |
@marcingrzejszczak I can build and travis can build. Maybe force update your maven cache when you build? |
Yeah I see that the builds pass - I have to have something done wrong on my side. Anyways - are we ready to merge or do you want me to do sth else? If not then I can squash the commits |
If you can build, I think I'm ready to merge |
Below you can find people who helped to create this solution Tomasz Nurkiewicz <tomasz.nurkiewicz@4finance.com> Marcin Zajaczkowski <marcin.zajaczkowski@4finance.com> Kamil Szymanski <kamil.szymanski@4finance.com> Michal Chmielarz <michal.chmielarz@4finance.com> Marcin Grzejszczak <marcin.grzejszczak@4finance.com> Jakub Nabdralik <jakub.nabrdalik@4finance.com> Urszula Choromanska <urszula.choromanska@4finance.com> Tomasz Dziurko <tomasz.dziurko@4finance.com> Tomasz Szymanski <tomasz.szymanski@4finance.com> Adam Chudzik <adam.chudzik@4finance.com>
d5c31fc
to
dad0505
Compare
I still couldn't build it locally but Travis says ok :) |
Once you merge - can you Tweet about us again :) ? |
And (if it's not a problem) you could mention about 4financeIT in Spring Weekly ;) |
Adding correlationId from 4financeIT micro-infra-spring
Merged, I'll have to defer to @joshlong as to what goes into Spring Weekly. |
e4financeIT CorrelationID PR
What I have done:
What I had to do:
What has to be done: