Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bean name "commonFeatures" could have a better naming #1229

Closed
junyongz opened this issue Apr 27, 2023 · 2 comments · Fixed by #1230
Closed

Bean name "commonFeatures" could have a better naming #1229

junyongz opened this issue Apr 27, 2023 · 2 comments · Fixed by #1230

Comments

@junyongz
Copy link

junyongz commented Apr 27, 2023

"org.springframework.cloud.client.CommonsClientAutoConfiguration$ActuatorConfiguration",
"org.springframework.cloud.client.CommonsClientAutoConfiguration$DiscoveryLoadBalancerConfiguration",
"discoveryClientHealthIndicator",
"discoveryCompositeHealthContributor",
"commonsFeatures",
"spring.cloud.discovery.client.health-indicator-org.springframework.cloud.client.discovery.health.DiscoveryClientHealthIndicatorProperties",
"org.springframework.cloud.client.CommonsClientAutoConfiguration",
"org.springframework.cloud.client.ReactiveCommonsClientAutoConfiguration",
 "org.springframework.cloud.client.loadbalancer.LoadBalancerDefaultMappingsProviderAutoConfiguration",

Comparing this commonFeatures bean names with others in spring cloud portfolio, it could be better.

@ryanjbaxter
Copy link
Contributor

Maybe something like springCloudCommonsFeatures

@omernaci
Copy link
Contributor

omernaci commented Apr 28, 2023

I would also like to make a suggestion. It can be updated as follows: getCommonsClientFeatures or commonsClientFeatures. This name could be more descriptive than original method name. The purpose of the method to specifically identify the set of features related to client-side load balancing and service discovery. I would happy to contribute to the final name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants