Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint ID 'service-registry' contains invalid characters #458

Closed
liuzhongkai opened this issue Dec 19, 2018 · 20 comments · Fixed by #701
Closed

Endpoint ID 'service-registry' contains invalid characters #458

liuzhongkai opened this issue Dec 19, 2018 · 20 comments · Fixed by #701
Labels
Projects
Milestone

Comments

@liuzhongkai
Copy link

2018-12-19 11:11:42.598 WARN 13196 --- [ main] o.s.boot.actuate.endpoint.EndpointId : Endpoint ID 'service-registry' contains invalid characters, please migrate to a valid format.

@liuzhongkai
Copy link
Author

spring-boot-starter-actuator 2.1.1.RELEASE

@spencergibb
Copy link
Member

It is only a warning that can be ignored for now.

@tanuja3088
Copy link

Facing same issue also unable to register my service to eureka it remains in STARTING status

@aflaifel
Copy link

facing the same issue and can't inject any values from application.yml file

@nintha
Copy link

nintha commented Apr 10, 2019

if EndpointId includes '-' or '.', it prints this warning.

// org.springframework.boot.actuate.endpoint.EndpointId.java
private static final Pattern WARNING_PATTERN = Pattern.compile("[\\.\\-]+");
// ...
// other codes
// ...
if (WARNING_PATTERN.matcher(value).find()) {
    logWarning(value);
}
// ...
// lots of other codes
// ...
private static void logWarning(String value) {
    if (logger.isWarnEnabled() && loggedWarnings.add(value)) {
        logger.warn("Endpoint ID '" + value + "' contains invalid characters, please migrate to a valid format.");
    }
}

@spencergibb
Copy link
Member

It is only a warning that can be ignored for now.

@nintha
Copy link

nintha commented Apr 10, 2019

It is only a warning that can be ignored for now.

Thanks for your reply. However, it is weird WARNING_PATTERN. Will it be fixed in the next version?

@linux5396
Copy link

It is only a warning that can be ignored for now.
exc. why I see an Instance from eureka website after set register-with-eureka and fetch-registry into false?

@antonkhvorov
Copy link

Any updates?

@spencergibb
Copy link
Member

No

@ryanjbaxter
Copy link
Contributor

There is an issue open in Boot to help address this problem spring-projects/spring-boot#18148

@ryanjbaxter ryanjbaxter added this to To do in Hoxton.M3 via automation Sep 5, 2019
@ryanjbaxter ryanjbaxter added this to To do in Greenwich.SR4 via automation Sep 5, 2019
@ryanjbaxter ryanjbaxter added this to the 2.1.4.RELEASE milestone Sep 5, 2019
@ryanjbaxter
Copy link
Contributor

We have communicated with the Boot team and they have decided that they will not remove support for ids with invalid characters until the next major release. At that point we will migrate the ids to avoid any breaking changes in a minor release.

@ryanjbaxter ryanjbaxter removed this from To do in Hoxton.M3 Sep 18, 2019
@ryanjbaxter ryanjbaxter removed this from To do in Greenwich.SR4 Sep 18, 2019
@ryanjbaxter ryanjbaxter removed this from the 2.1.4.RELEASE milestone Sep 18, 2019
@JWThewes
Copy link

Still not resolved with Hoxton...any plans on fixing this. I don't like warnings in my startup log ;)

@spencergibb
Copy link
Member

No current plans until a major release as it would be a breaking change

@spencergibb spencergibb added this to To do in 2020.0.0-M1 via automation Mar 29, 2020
@spencergibb spencergibb added this to the 3.0.0.M1 milestone Mar 29, 2020
2020.0.0-M1 automation moved this from To do to Done Mar 29, 2020
@spencergibb spencergibb reopened this Mar 29, 2020
2020.0.0-M1 automation moved this from Done to In progress Mar 29, 2020
2020.0.0-M1 automation moved this from In progress to Done Mar 29, 2020
@ramazansakin
Copy link

Still the same warning :/

@spencergibb
Copy link
Member

@ramazansakin saying that without saying what version you are using isn't very helpful

@ramazansakin
Copy link

Cloud : Hoxton.SR9
spring : 2.2.12

any other info ? @spencergibb

@spencergibb
Copy link
Member

This was only fixed in 2020.0.0 and will not be fixed in hoxton because it is a breaking change

@ArberChang
Copy link

Still not resolved with Hoxton...any plans on fixing this. I don't like warnings in my startup log ;)

me too

@spencergibb
Copy link
Member

@ArberChang see the comment above yours. Since it's a breaking change it will NOT be fixed in hoxton.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
2020.0.0-M1
  
Done