Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve migration of legacy endpoint ids #20703

Closed
philippn opened this issue Mar 27, 2020 · 1 comment
Closed

Improve migration of legacy endpoint ids #20703

philippn opened this issue Mar 27, 2020 · 1 comment
Labels
status: superseded An issue that has been superseded by another

Comments

@philippn
Copy link

Hi there,

This is a essentially a follow-up on #18148 . As far as I understand this property was essentially introduced to help out with some warnings that are issued when Spring Cloud is on the classpath.

There is one notably case, where the current implementation doesn't cut it though: As per spring-cloud/spring-cloud-commons#458, Spring Cloud still causes a warning message because of an endpoint called service-registry. The current implementation of the legacy id migration doesn't fix this, because it does not take the dash into account.

Thanks for your time and keep up the good work!
@philippn philippn mentioned this issue Mar 27, 2020
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 27, 2020
@mbhave mbhave added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 2, 2020
@mbhave mbhave added this to the 2.2.x milestone Apr 2, 2020
Larisho added a commit to Larisho/spring-boot that referenced this issue May 28, 2020
@Larisho
Fixes spring-projectsgh-20703
bf64033
@Larisho Larisho mentioned this issue May 28, 2020
Closed
@philwebb
Copy link
Member

Closing in favor of PR #21615

@philwebb philwebb added status: superseded An issue that has been superseded by another and removed type: bug A general bug labels May 29, 2020
@philwebb philwebb removed this from the 2.2.x milestone May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@philippn @philwebb @mbhave @spring-projects-issues