Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support autoconfigure WeightedServiceInstanceListSupplier #1163

Merged
merged 3 commits into from Oct 27, 2022
Merged

Conversation

jizhuozhi
Copy link
Contributor

@jizhuozhi jizhuozhi commented Oct 27, 2022

Enable configuring WeightedServiceInstanceListSupplier via spring.cloud.loadbalancer.configurations

@jizhuozhi
Copy link
Contributor Author

Hello, @OlgaMaciaszek , PLAT, thanks.

Copy link
Collaborator

@OlgaMaciaszek OlgaMaciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jizhuozhi Thanks for submitting this PR. There's just a minor thing in the doc to fix. Have added a comment - please address it.

docs/src/main/asciidoc/spring-cloud-commons.adoc Outdated Show resolved Hide resolved
@OlgaMaciaszek OlgaMaciaszek added this to the 4.0.0-RC1 milestone Oct 27, 2022
@jizhuozhi
Copy link
Contributor Author

Hello, @OlgaMaciaszek . Document has fixed, but it's copied from other chapters, we should also fix them :).

@OlgaMaciaszek OlgaMaciaszek merged commit aef6406 into spring-cloud:main Oct 27, 2022
Copy link
Collaborator

@OlgaMaciaszek OlgaMaciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jizhuozhi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants