Fix DelegatingServiceInstanceListSupplier must #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
respect SelectedInstanceCallback on its delegate. Motivation behind is that some load balancer implementations like the RoundRobinLoadBalancer to call selectedServiceInstance on the ServiceInstanceListSupplier after choosing the next instance. However, when a ServiceInstanceListSupplier in wrapped by the DelegatingServiceInstanceListSupplier this functionality breaks, as DelegatingServiceInstanceListSupplier is not implementing SelectedInstanceCallback and therfore does ignoring that its delegate might also do. This might break the functionality of the delegate. Fixes spring-cloudgh-1221.
|
@spencergibb @OlgaMaciaszek anybody? |
|
Thanks for providing the PR, @HJK181. Will take a look at it. |
OlgaMaciaszek
requested changes
May 30, 2023
There was a problem hiding this comment.
Hello @HJK181, thanks for submitting the PR. It looks good, but there are some cosmetic changes that need to be made - please address the comments. Also, please update the forst line of the copyright clause on top of each changed file to -2023.
.../java/org/springframework/cloud/loadbalancer/core/DelegatingServiceInstanceListSupplier.java
Outdated
Show resolved
Hide resolved
...st/java/org/springframework/cloud/loadbalancer/core/TestSelectedServiceInstanceSupplier.java
Outdated
Show resolved
Hide resolved
OlgaMaciaszek
requested changes
May 30, 2023
There was a problem hiding this comment.
Thanks, @HJK181 . Have added one more comment. Please take a look.
.../java/org/springframework/cloud/loadbalancer/core/DelegatingServiceInstanceListSupplier.java
Show resolved
Hide resolved
HJK181
force-pushed
the
selected-instance-callback-in-delagating-instance-supplier
branch
from
d2ddb6a
to
5b24a9b
Compare
OlgaMaciaszek
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
respect
SelectedInstanceCallbackon its delegate. Motivation behind is that some load balancer implementations like theRoundRobinLoadBalancerto callselectedServiceInstanceon theServiceInstanceListSupplierafter choosing the next instance. However, when aServiceInstanceListSupplierin wrapped by theDelegatingServiceInstanceListSupplierthis functionality breaks, asDelegatingServiceInstanceListSupplieris not implementingSelectedInstanceCallbackand therefore does ignoring that its delegate might also do. This might break the functionality of the delegate. Fixes gh-1221.