Refresh Scope on restart. #1266
Conversation
| synchronized (lifecycleMonitor) { | ||
| if (!isRunning()) { | ||
| if (LOG.isDebugEnabled()) { | ||
| LOG.debug("Refreshing context on restart."); |
There was a problem hiding this comment.
I'd say this is important enough for info rather than debug
|
@Buzzardo could you please take a look at the doc changes? |
| [refresh-scope-on-restart] | ||
| === Refresh Scope on Restart | ||
|
|
||
| In order to allow seamlessly refreshing beans on restart, which is especially useful for applications running with JVM Checkpoint Restore (for example with https://github.com/CRaC[Project CRaC]), we now instantiate a `RefreshScopeLifecycle` bean that will trigger Context Refresh on restart, resulting in rebinding configuration properties and refreshing any `@RefreshScope`-annotated beans. This behaviour can be disabled by setting the value of `spring.cloud.refresh.on-restart.enabled` to `false`. |
There was a problem hiding this comment.
That long and complex sentence is hard to parse in one pass, so please change it to:
Seamlessly refreshing beans on restart is especially useful for applications that run with JVM Checkpoint Restore (such as https://github.com/CRaC[Project CRaC]). To allow this ability, we now instantiate a RefreshScopeLifecycle bean that triggers Context Refresh on restart, resulting in rebinding configuration properties and refreshing any beans annotated with @RefreshScope. You can disable this behavior by setting spring.cloud.refresh.on-restart.enabled to false.
There was a problem hiding this comment.
Thanks @Buzzardo - will change.
No description provided.