Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1285 Spring Cloud activates unexpected profiles when some conditions met #1286

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Fix #1285 Spring Cloud activates unexpected profiles when some conditions met #1286

merged 2 commits into from
Oct 18, 2023

Conversation

leovx
Copy link
Contributor

@leovx leovx commented Sep 29, 2023

@leovx leovx mentioned this pull request Sep 29, 2023
Closed
@yanhom1314
Copy link

yanhom1314 commented Oct 11, 2023 •
edited

I recently upgraded to version 3.1.4 and encountered an issue with retrieving profiles from different PropertySources. I want to know if this is considered a bug, as previous versions did not have this problem.

@leovx
Copy link
Contributor Author

leovx commented Oct 11, 2023

I recently upgraded to version 3.1.4 and encountered an issue with retrieving profiles from different PropertySources. I want to know if this is considered a bug, as previous versions did not have this problem.

Not quite aware of your problem, coz I only found this issue comparing 3.1.7 and 3.1.6. You can check if your issue persists in the latest version and possibly provide a POC.

ryanjbaxter
ryanjbaxter requested changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@ryanjbaxter ryanjbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to change the PR to be against the 3.1.x branch and also fix the checkstyle errors.

@ryanjbaxter ryanjbaxter linked an issue Oct 17, 2023 that may be closed by this pull request
Spring Cloud activates unexpected profiles when some conditions met #1285
Closed
@leovx leovx changed the base branch from main to 3.1.x October 18, 2023 13:35
@leovx
Copy link
Contributor Author

leovx commented Oct 18, 2023

You will need to change the PR to be against the 3.1.x branch and also fix the checkstyle errors.

Code style issues fixed and rebased to 3.1.x.

@ryanjbaxter ryanjbaxter merged commit 9b2d247 into spring-cloud:3.1.x Oct 18, 2023
1 check passed
@renovate renovate bot mentioned this pull request Dec 22, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanjbaxter ryanjbaxter Awaiting requested review from ryanjbaxter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spring Cloud activates unexpected profiles when some conditions met
4 participants
@leovx @yanhom1314 @ryanjbaxter @spring-cloud-issues