Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring.cloud.config.retry.useRandomPolicy not being applied #2379

Closed
marnee01 opened this issue Jan 30, 2024 · 2 comments · Fixed by #2380
Closed

spring.cloud.config.retry.useRandomPolicy not being applied #2379

marnee01 opened this issue Jan 30, 2024 · 2 comments · Fixed by #2380
Labels
Milestone

Comments

@marnee01
Copy link
Contributor

marnee01 commented Jan 30, 2024

I see in #2353, that support was added for the spring.cloud.config.retry.useRandomPolicy property. However, it's not actually being applied when I run one of our ConfigServer clients. (I observed this by adding a break point in RetryProperties,isUseRandomPolicy(). It's never being called. Note that we have spring.config.use-legacy-processing=true.

Analysis: The retry appears to be configured in ConfigServiceBootstrapConfiguration.configServerRetryInterceptor. In spring-cloud-config-client-4.0.5.jar, I see that the RetryInterceptorBuilder is not calling the retryPolicy builder method. Was that a miss in the above-mentioned PR?

@ryanjbaxter
Copy link
Contributor

Yeah I think you are right. You are using bootstrap configuration then and not leveraging spring.config.import?

@marnee01
Copy link
Contributor Author

marnee01 commented Feb 1, 2024

Yeah I think you are right. You are using bootstrap configuration then and not leveraging spring.config.import?

Yes, that's correct.

ryanjbaxter added a commit to ryanjbaxter/spring-cloud-config that referenced this issue Feb 1, 2024
@ryanjbaxter ryanjbaxter added this to the 4.1.1 milestone Feb 1, 2024
ryanjbaxter added a commit that referenced this issue Feb 1, 2024
Fixes #2379

Co-authored-by: Ryan Baxter <524254+ryanjbaxter@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants