Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting git.basedir to relative directory causes NPE #1471

Merged
merged 1 commit into from Jan 13, 2020

Conversation

hekonsek
Copy link
Contributor

Cherry picked #1456 into 2.1.x branch as requested by @spencergibb .

@hekonsek hekonsek changed the title AbstractScmAccessor should apply logic from setBasedir AbstractScmAccessor should apply logic from setBasedir (2.1.x backport) Sep 19, 2019
@codecov
Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #1471 into master will increase coverage by 0.82%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1471      +/-   ##
============================================
+ Coverage     77.29%   78.11%   +0.82%     
+ Complexity     1042     1010      -32     
============================================
  Files           131      120      -11     
  Lines          3827     3624     -203     
  Branches        533      516      -17     
============================================
- Hits           2958     2831     -127     
+ Misses          688      610      -78     
- Partials        181      183       +2
Impacted Files Coverage Δ Complexity Δ
...oud/config/server/support/AbstractScmAccessor.java 80.61% <100%> (+1.02%) 33 <0> (+1) ⬆️
...ent/EnvironmentEncryptorEnvironmentRepository.java 90.47% <0%> (-2.86%) 8% <0%> (-4%)
.../environment/AbstractScmEnvironmentRepository.java 89.47% <0%> (-0.53%) 4% <0%> (-1%)
...erver/environment/NativeEnvironmentRepository.java 84.89% <0%> (-0.11%) 44% <0%> (-1%)
...nfig/server/environment/EnvironmentController.java 89.58% <0%> (-0.11%) 40% <0%> (-3%)
...g/monitor/EnvironmentMonitorAutoConfiguration.java 100% <0%> (ø) 2% <0%> (ø) ⬇️
...environment/MultipleJGitEnvironmentRepository.java 75.83% <0%> (ø) 35% <0%> (ø) ⬇️
...nt/EnvironmentRepositoryPropertySourceLocator.java 100% <0%> (ø) 3% <0%> (ø) ⬇️
...oud/config/server/resource/ResourceController.java 84.9% <0%> (ø) 20% <0%> (ø) ⬇️
...amework/cloud/config/client/ConfigClientWatch.java 35% <0%> (ø) 6% <0%> (ø) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76dabad...6395f61. Read the comment docs.

@spencergibb spencergibb changed the title AbstractScmAccessor should apply logic from setBasedir (2.1.x backport) Setting git.basedir to relative directory causes NPE Jan 13, 2020
@spencergibb spencergibb added this to In progress in Greenwich.SR5 via automation Jan 13, 2020
@spencergibb spencergibb added this to In progress in Hoxton.SR3 via automation Jan 13, 2020
@spencergibb spencergibb added this to the 2.1.6.RELEASE milestone Jan 13, 2020
@spencergibb spencergibb merged commit 3729648 into spring-cloud:master Jan 13, 2020
Greenwich.SR5 automation moved this from In progress to Done Jan 13, 2020
Hoxton.SR3 automation moved this from In progress to Done Jan 13, 2020
spencergibb added a commit that referenced this pull request Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Greenwich.SR5
  
Done
Hoxton.SR3
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants