Do not discard the root exception when things go wrong #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root exception can detail an important root cause. For example with native-images it can indicate a flag you need to set for the native-image to compile correctly: Caused by: java.net.MalformedURLException: Accessing an URL protocol that was not enabled. The URL protocol http is supported but not enabled by default. It must be enabled by adding the -H:EnableURLProtocols=http option to the native-image command.
Codecov Report
@@ Coverage Diff @@
## master #1743 +/- ##
=========================================
Coverage 77.31% 77.31%
Complexity 1250 1250
=========================================
Files 160 160
Lines 4610 4610
Branches 615 615
=========================================
Hits 3564 3564
Misses 809 809
Partials 237 237
Continue to review full report at Codecov.
|
|
Cherry-picked to 2.2.x and merged forward via bf2c61f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root exception can detail an important root cause. For
example with native-images it can indicate a flag you need
to set for the native-image to compile correctly:
Caused by: java.net.MalformedURLException:
Accessing an URL protocol that was not enabled. The URL
protocol http is supported but not enabled by default.
It must be enabled by adding the -H:EnableURLProtocols=http
option to the native-image command.