Implement a better equals and hashcode method ConfigServerConfigDataResource #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esource Spring Boot keeps a list of ConfigDataResources and will call contains on the list to determine whether it should load the resource. Our hashcode and equals methods were using variables in ConfigServerConfigDataResource which had no bearing on the configuration that would be loaded, so this change simplifies this to make sure two ConfigServerConnfigDataResources would be considered equal if they would end up making the same request to the config server for configuration.
spencergibb
reviewed
Jun 9, 2023
| @@ -73,7 +73,7 @@ void context() { | |||
| verify(rest).exchange(eq("http://localhost:8888/{name}/{profile}"), eq(HttpMethod.GET), | |||
| ArgumentMatchers.any(HttpEntity.class), eq(Environment.class), eq("application"), | |||
| ArgumentMatchers.<String>any()); | |||
| verify(rest, times(2)).exchange(eq("http://localhost:8888/{name}/{profile}"), eq(HttpMethod.GET), | |||
| verify(rest, times(1)).exchange(eq("http://localhost:8888/{name}/{profile}"), eq(HttpMethod.GET), | |||
There was a problem hiding this comment.
Awesome, we were testing for the bug 🤦🏻♂️
There was a problem hiding this comment.
Well to be fair, we didn't know how this should have worked ;)
spencergibb
approved these changes
Jun 9, 2023
This was referenced Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring Boot keeps a list of ConfigDataResources and will call contains on the list to determine whether it should load the resource. Our hashcode and equals methods were using variables in ConfigServerConfigDataResource which had no bearing on the configuration that would be loaded, so this change simplifies this to make sure two ConfigServerConnfigDataResources would be considered equal if they would end up making the same request to the config server for configuration.