Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataSource should prefer org.apache.tomcat.jdbc.DataSource if available #8

Closed
dsyer opened this issue Oct 16, 2013 · 1 comment
Closed

DataSource should prefer org.apache.tomcat.jdbc.DataSource if available #8

dsyer opened this issue Oct 16, 2013 · 1 comment

Comments

@dsyer
Copy link
Contributor

dsyer commented Oct 16, 2013

The high-performance Tomcat DataSource is infinitely preferable to DBCP (and to the Tomcat re-jarred version that Spring Cloud currently falls back to if available). If it is on the classpath it should be used in preference.
@ramnivas
Copy link
Contributor

Fixed in a1ec1f6

scottfrederick pushed a commit to scottfrederick/spring-cloud-connectors that referenced this issue Mar 29, 2017
@bclozel
Merge pull request spring-cloud#8 from dsyer/patch-1
1a150a3 
Fix "rm -rf" instruictions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsyer @ramnivas