Handle drivers which don't support URL-encoding (1.x) #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.2.6 introduced a change to URL-encode credentials in JDBC connection strings by default. This was to prevent special characters from interfering with connections, but unfortunately some drivers can't handle the encoding. Also in some clouds, the JDBC URL is passed to us in URL encoded form. Again, in the case where the driver is unable to URL-decode the URL itself, this causes connection failures. This commit introduces `UrlDecodingDataSource`, which is returned in all cases by whichever `DataSourceCreator` is in play. `UrlDecodingDataSource` transparently delegates to an underlying `DataSource`, except in the case where a connection attempt is made and no previous connection attempt has been successful. In this case, if the connection attempt with the configured JDBC URL fails, a test connection is attempted using a URL-decoded version of the JDBC URL. If this is successful, the underlying `DataSource` is updated with the decoded JDBC URL and used to provide a final connection, which is returned to the client. Fixes spring-cloudgh-237
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.2.6 introduced a change to URL-encode credentials in JDBC connection
strings by default. This was to prevent special characters from
interfering with connections, but unfortunately some drivers can't
handle the encoding. Also in some clouds, the JDBC URL is passed to us
in URL encoded form. Again, in the case where the driver is unable to
URL-decode the URL itself, this causes connection failures.
This commit introduces
UrlDecodingDataSource, which is returned in allcases by whichever
DataSourceCreatoris in play.UrlDecodingDataSourcetransparently delegates to an underlyingDataSource, except in the case where a connection attempt is made andno previous connection attempt has been successful. In this case, if the
connection attempt with the configured JDBC URL fails, a test connection
is attempted using a URL-decoded version of the JDBC URL. If this is
successful, the underlying
DataSourceis updated with the decoded JDBCURL and used to provide a final connection, which is returned to the
client.
Fixes gh-237 for the 1.x branch