fix ipv6 formatting for consul API #287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ add test
|
@knalx Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@knalx Thank you for signing the Contributor License Agreement! |
spencergibb
requested changes
Mar 3, 2017
There was a problem hiding this comment.
This change breaks two tests.
Results :
Tests in error:
getMetadataWorks(org.springframework.cloud.consul.discovery.ConsulDiscoveryClientCustomizedTests): java.net.UnknownHostException: testConsulDiscovery2Host: unknown error
testGetFilteredListOfServers(org.springframework.cloud.consul.discovery.HealthServiceServerListFilterTests): java.net.UnknownHostException: serviceaddrPASSING: unknown error
- fix exception checking - add test
|
Sorry, did not check it. Now it works. |
spencergibb
added a commit
that referenced
this pull request
Mar 7, 2017
* pull287: Fixes ipv6 formatting for consul discovery.
spencergibb
approved these changes
Mar 7, 2017
|
Squash and merged with some polish via 0069798 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When consul api return IPv6 address - spring cloud consul can't parse it correctly - using it as is.
Added IPv6 address format modification.