Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Binary message / http body #664

Closed
marcingrzejszczak opened this issue Jun 8, 2018 · 1 comment · Fixed by #818
Closed

Add support for Binary message / http body #664

marcingrzejszczak opened this issue Jun 8, 2018 · 1 comment · Fixed by #818
Assignees

Comments

@marcingrzejszczak
Copy link
Contributor

Currently, we convert everything back and forth to JSON and JSON Paths. We should allow an option that the body are bytes (which we can try to convert to JSON to change it into JSON Paths) but in case that's not true, we should try to support the flow anyways.

Corresponding SO issue - https://stackoverflow.com/questions/50757969/spring-cloud-contract-is-it-possible-use-a-binary-payload-in-message-body-of-c

@sfw185
Copy link

sfw185 commented Jun 13, 2018

The first endpoint I was adding to an existing project required returning a PDF as the body.

I would suggest the behaviour be determined by a response header. Content-Disposition: attachment seems to be a standard way of hinting that the consumer/browser that the response should be downloaded.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition

@marcingrzejszczak marcingrzejszczak changed the title Add support for Binary message body Add support for Binary message / http body Jun 13, 2018
@OlgaMaciaszek OlgaMaciaszek self-assigned this Sep 3, 2018
@marcingrzejszczak marcingrzejszczak self-assigned this Nov 15, 2018
@OlgaMaciaszek OlgaMaciaszek added this to To do in Greenwich.RC1 via automation Dec 10, 2018
@OlgaMaciaszek OlgaMaciaszek moved this from To do to In progress in Greenwich.RC1 Dec 10, 2018
@OlgaMaciaszek OlgaMaciaszek added this to To do in Greenwich.RC2 via automation Dec 10, 2018
@OlgaMaciaszek OlgaMaciaszek removed this from In progress in Greenwich.RC1 Dec 10, 2018
Greenwich.RC2 automation moved this from To do to Done Dec 15, 2018
marcingrzejszczak added a commit that referenced this issue Dec 15, 2018
with this change we're adding support for binary payloads both for HTTP and messaging.

fixes #664
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Greenwich.RC2
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants