Pact Contract #188
Merged
Pact Contract #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 58.74% (diff: 65.21%)@@ master #188 diff @@
==========================================
Files 198 199 +1
Lines 5660 5846 +186
Methods 0 0
Messages 0 0
Branches 955 1013 +58
==========================================
+ Hits 3316 3434 +118
- Misses 1962 1988 +26
- Partials 382 424 +42
|
the class is tested via JsonToJsonPathConverter
TODO: - added some code in RecursiveFileConverter that needs additional unit tests - the tests generated from Pact loose their indent for some reason - StubGeneratorProvider needs additional unit tests
I wanted it to work with optional dependencies but it won't work like this. We'll need an explicit dependency for every converter
marcingrzejszczak
force-pushed
the
issues_#96_pact_contract
branch
from
d8187fc
to
30217ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this introduces support of Pact files as input contracts. In other words instead of using the Groovy DSL you can define your contracts with Pact files.
fixes #96