Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle old ctr props #1715

Closed
jvalkeal opened this issue May 24, 2021 · 1 comment
Closed

Handle old ctr props #1715

jvalkeal opened this issue May 24, 2021 · 1 comment
Assignees
@jvalkeal
Milestone
3.1.0-RC1

Comments

@jvalkeal
Copy link
Contributor

With new task launch ui we moved to not require task name in props anymore so that those are portable between tasks.

app.t1.timestamp.format=yyyy

On a server we still handle old style:

app.ctr1.t1.timestamp.format=yyyy

Need to think how we represent this in UI.
@jvalkeal jvalkeal added this to the 3.1.0-RC1 milestone May 24, 2021
@jvalkeal jvalkeal self-assigned this May 24, 2021
@sabbyanandan sabbyanandan assigned oodamien and unassigned jvalkeal May 24, 2021
@sabbyanandan
Copy link
Contributor

@oodamien: Feel free to share your thoughts on the UX. We need to be able to evaluate if it is possible to wrap it in RC, though.

@jvalkeal jvalkeal assigned jvalkeal and unassigned oodamien May 26, 2021
jvalkeal added a commit to jvalkeal/spring-cloud-dataflow-ui that referenced this issue May 26, 2021
@jvalkeal
Add migration concept for old ctr app properties
141c689 
- Add Some UI fu to let user to automatically migrate
  from old ctr app properties(given in 2.7.x line) and
  migrate those to new expected ctr options.
- For this work correctly also spring-cloud#1721 needs to be fixed which
  is a bigger topic and will get done in a separate commit.
- Fixes spring-cloud#1715
@jvalkeal jvalkeal mentioned this issue May 26, 2021
Closed
@cppwfs cppwfs closed this as completed in 328e796 May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jvalkeal jvalkeal

Labels
None yet
Projects
None yet
Milestone
3.1.0-RC1
Development

Successfully merging a pull request may close this issue.

Add migration concept for old ctr app properties jvalkeal/spring-cloud-dataflow-ui
3 participants
@jvalkeal @oodamien @sabbyanandan