Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation and configuration for supported resource types for registered apps #1049

Closed
trisberg opened this issue Dec 8, 2016 · 2 comments
Labels
type/enhancement Is an enhancement request

Comments

@trisberg
Copy link
Member

trisberg commented Dec 8, 2016

Different server implementations support different types of resources, some support Maven and some only support Docker resources. We should have a way to configure the server with supported types and validate when resources are registered. That way we could provide an error when someone registers an unsupported resource type.

https://github.com/spring-cloud/spring-cloud-dataflow-server-kubernetes/issues/157

@trisberg trisberg added the type/enhancement Is an enhancement request label Dec 8, 2016
@trisberg trisberg changed the title Add validation and configuration for supported resource type for registered apps Add validation and configuration for supported resource types for registered apps Dec 8, 2016
@markfisher
Copy link
Contributor

Maybe we can just add a supportsScheme(String scheme) method to the DelegatingResourceLoader.

One thought on this though... we can validate the "type", but it's still completely possible that a user registers a bogus URI. We probably cannot eagerly validate anything more than the scheme, unless we want to provide a boolean flag for eager validation.

@sabbyanandan
Copy link
Contributor

The core validation routines are applied via #2345 and friends. They include for both maven and docker resource types.

corneil pushed a commit that referenced this issue Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Is an enhancement request
Projects
None yet
Development

No branches or pull requests

3 participants