Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail with Boot 1.5.4 #1559

Closed
trisberg opened this issue Jun 27, 2017 · 3 comments
Closed

Tests fail with Boot 1.5.4 #1559

trisberg opened this issue Jun 27, 2017 · 3 comments
Assignees
@ilayaperumalg
Labels
type/bug Is a bug report
Milestone
1.2.2.RELEASE

Comments

@trisberg
Copy link
Member

The spring-cloud-dataflow-shell-core tests fail when upgrading Boot dependency to 1.5.4

Tests in error: 
  testAggregateCounterInteractions(org.springframework.cloud.dataflow.shell.command.AggregateCounterCommandsTests): Failure.  CommandResult = CommandResult [success=false, result=null, exception=org.springframework.cloud.dataflow.rest.client.DataFlowClientException: Page size must not be less than one!(..)
  testCounterInteractions(org.springframework.cloud.dataflow.shell.command.CounterCommandsTests): Failure.  CommandResult = CommandResult [success=false, result=null, exception=org.springframework.cloud.dataflow.rest.client.DataFlowClientException: Page size must not be less than one!(..)
  testFVCInteractions(org.springframework.cloud.dataflow.shell.command.FieldValueCounterCommandsTests): Failure.  CommandResult = CommandResult [success=false, result=null, exception=org.springframework.cloud.dataflow.rest.client.DataFlowClientException: Page size must not be less than one!(..)
@trisberg trisberg added this to the 1.2.2.RELEASE milestone Jun 27, 2017
@trisberg trisberg added type/bug Is a bug report ready labels Jun 27, 2017
@trisberg
Copy link
Member Author

trisberg commented Jun 27, 2017 •
edited

Related to #1382 #1383 and #1545

@ilayaperumalg ilayaperumalg mentioned this issue Jun 27, 2017
Closed
@ilayaperumalg
Copy link
Contributor

@trisberg This issue is related to the Metrics controllers not returning the paged resources and created a PR here: spring-attic/spring-analytics#7 for spring-analytics.

The data flow is already using 1.1.3.BUILD-SNAPSHOT and hence, the 1.1.3 release on spring-analytics would be sufficient for this. The tests look good after this change.

trisberg added a commit to trisberg/spring-cloud-dataflow that referenced this issue Jun 27, 2017
@trisberg
Version upgrades
499c4df 
- update to spring-cloud-build 1.3.3.RELEASE

- upgrade to Dalston.SR1

- update to use deployer 1.2.1 release

- update to task 1.2.1 snapshot

Resolves spring-cloud#1543
Resolves spring-cloud#1555
Resolves spring-cloud#1556

Depends on spring-cloud#1559 and spring-attic/spring-analytics#8
@trisberg trisberg mentioned this issue Jun 27, 2017
Closed
@trisberg
Copy link
Member Author

This is resolved via spring-attic/spring-analytics#8

ilayaperumalg pushed a commit that referenced this issue Jun 27, 2017
@trisberg @ilayaperumalg
Version upgrades
6e60dbb 
- update to spring-cloud-build 1.3.3.RELEASE

- upgrade to Dalston.SR1

- update to use deployer 1.2.1 release

- update to task 1.2.1 snapshot

Resolves #1543
Resolves #1555
Resolves #1556

Depends on #1559 and spring-attic/spring-analytics#8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilayaperumalg ilayaperumalg

Labels
type/bug Is a bug report
Projects
None yet
Milestone
1.2.2.RELEASE
Development

No branches or pull requests
2 participants
@trisberg @ilayaperumalg