Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TaskDefinition Detail not returning DSL for CTRs #2763

Closed
cppwfs opened this issue Jan 17, 2019 · 0 comments · Fixed by #2822
Closed

TaskDefinition Detail not returning DSL for CTRs #2763

cppwfs opened this issue Jan 17, 2019 · 0 comments · Fixed by #2822
Assignees
@cppwfs
Labels
type/bug Is a bug report
Milestone
2.0.0.M2

Comments

@cppwfs
Copy link
Contributor

cppwfs commented Jan 17, 2019 •
edited by sabbyanandan

After investigation it appears that the sanitizeTaskDSL is not correctly cleansing the task DSL for CTR's as shown here:

https://github.com/spring-cloud/spring-cloud-dataflow/blob/master/spring-cloud-dataflow-rest-resource/src/main/java/org/springframework/cloud/dataflow/rest/support/ArgumentSanitizer.java#L161-L165

In this case the TaskDefinition is properly populated but the TaskDefinitionBuilder is not populating the SanitizedTaskDefinition properly. And the TaskDefinitionToDslConverter.toDsl will need to be updated or replaced to handle the CTR Scenario.

Refer to spring-cloud/spring-cloud-dataflow-ui#1026 for additional information.
@cppwfs cppwfs added backport-1.7.x type/bug Is a bug report labels Jan 17, 2019
@cppwfs cppwfs mentioned this issue Jan 17, 2019
Closed
@sabbyanandan sabbyanandan added this to the 2.0.0.M2 milestone Jan 17, 2019
@cppwfs cppwfs added in progress and removed ready labels Jan 17, 2019
@sabbyanandan sabbyanandan assigned cppwfs and unassigned cppwfs Jan 23, 2019
@sabbyanandan sabbyanandan modified the milestones: 2.0.0.M2, 2.0.0.RC1 Jan 29, 2019
cppwfs pushed a commit to cppwfs/spring-cloud-dataflow that referenced this issue Jan 31, 2019
Resolves missing DSL in task detail request
baa85cb 
resolves spring-cloud#2763
@cppwfs cppwfs mentioned this issue Jan 31, 2019
Merged
@cppwfs cppwfs added in pr and removed ready labels Jan 31, 2019
cppwfs pushed a commit to cppwfs/spring-cloud-dataflow that referenced this issue Jan 31, 2019
Resolves missing DSL in task detail request
c131cf0 
resolves spring-cloud#2763
markpollack pushed a commit that referenced this issue Feb 1, 2019
Resolves missing DSL in task detail request (#2822)
8e28fd4 
resolves #2763
@markpollack markpollack removed the in pr label Feb 1, 2019
@sabbyanandan sabbyanandan modified the milestones: 2.0.0.RC1, 2.0.0.M2 Feb 1, 2019
@sabbyanandan sabbyanandan mentioned this issue Feb 1, 2019
Closed
cppwfs pushed a commit that referenced this issue Feb 1, 2019
Resolves missing DSL in task detail request
462a2d4 
resolves #2763

Backport change to support correct name for sanitize
@ilayaperumalg ilayaperumalg mentioned this issue Feb 2, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cppwfs cppwfs

Labels
type/bug Is a bug report
Projects
None yet
Milestone
2.0.0.M2
Development

Successfully merging a pull request may close this issue.

Resolves missing DSL in task detail request cppwfs/spring-cloud-dataflow
3 participants
@markpollack @cppwfs @sabbyanandan