Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Access Token to the CTR #3418

Closed
ghillert opened this issue Aug 6, 2019 · 1 comment
Closed

Provide Access Token to the CTR #3418

ghillert opened this issue Aug 6, 2019 · 1 comment
Assignees
@ghillert
Labels
branch/2.2.x Issue for a branch
Milestone
Iteration 151 -> ...

Comments

@ghillert
Copy link
Contributor

ghillert commented Aug 6, 2019 •
edited

  • Provide the OAuth Access Token as a command-line argument to the CTR (if available)
  • Move OAuth2AccessTokenProvidingClientHttpRequestInterceptor to Common Security
    • This will allow for re-use of this class in the Composed Task Runner

Depends on:

spring-attic/spring-cloud-task-app-starters-composed-task-runner#62
spring-cloud/spring-cloud-common-security-config#58
@ghillert ghillert mentioned this issue Aug 6, 2019
Closed
@ghillert ghillert self-assigned this Aug 6, 2019
@sabbyanandan sabbyanandan added this to the Iteration 151 -> 2.3.0.M1 milestone Aug 9, 2019
@ghillert ghillert changed the title Move OAuth2AccessTokenProvidingClientHttpRequestInterceptor to Common Security Provide Access Token to the CTR Aug 9, 2019
This was referenced Aug 9, 2019
Closed
Closed
Merged
cppwfs pushed a commit to cppwfs/spring-cloud-dataflow that referenced this issue Aug 16, 2019
@ghillert
spring-cloudgh-3418 Provide Access Token to the CTR
42f5b17 
- Provide the OAuth Access Token as a command-line argument to the CTR (if available)
- Move `OAuth2AccessTokenProvidingClientHttpRequestInterceptor` to Common Security
  - This will allow for re-use of this class in the Composed Task Runner

spring-cloudgh-3418 Polishing

spring-cloudgh-3418 Code review changes

spring-cloudgh-3418 Polishing

spring-cloudgh-3418 Add tests, remove deprecations, provide token as property not as argument

Polishing on merge
@sabbyanandan
Copy link
Contributor

Addressed in 42f5b17.

@sabbyanandan sabbyanandan added the branch/2.2.x Issue for a branch label Aug 20, 2019
cppwfs pushed a commit to cppwfs/spring-cloud-dataflow that referenced this issue Aug 21, 2019
@ghillert
spring-cloudgh-3418 Provide Access Token to the CTR
0717ee6 
- Provide the OAuth Access Token as a command-line argument to the CTR (if available)
- Move `OAuth2AccessTokenProvidingClientHttpRequestInterceptor` to Common Security
  - This will allow for re-use of this class in the Composed Task Runner

spring-cloudgh-3418 Polishing

spring-cloudgh-3418 Code review changes

spring-cloudgh-3418 Polishing

spring-cloudgh-3418 Add tests, remove deprecations, provide token as property not as argument

Polishing on merge
@ilayaperumalg ilayaperumalg mentioned this issue Aug 23, 2019
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghillert ghillert

Labels
branch/2.2.x Issue for a branch
Projects
None yet
Milestone
Iteration 151 -> SCDF 2.3.0.M1
Development

Successfully merging a pull request may close this issue.

gh-3418 Provide Access Token to the CTR
2 participants
@ghillert @sabbyanandan