Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug capabilities to LocalAppDeployer #369

Closed
ericbottard opened this issue Feb 5, 2016 · 3 comments
Closed

Add debug capabilities to LocalAppDeployer #369

ericbottard opened this issue Feb 5, 2016 · 3 comments
Assignees
@aclement

Comments

@ericbottard
Copy link
Contributor

No description provided.

@sabbyanandan sabbyanandan changed the title Remove InProcessModuleDeployer Add debug capabilities to LocalAppDeployer Mar 14, 2016
@sabbyanandan sabbyanandan added this to the M3 milestone Mar 14, 2016
This was referenced Apr 7, 2016
Closed
Closed
@aclement
Copy link
Contributor

aclement commented Apr 7, 2016

A pair of PRs now enable debugging with local deployer. Works for me but there are open questions. I raised the PRs to drive the discussion:
PR on deployer: spring-cloud/spring-cloud-deployer#35
PR on dataflow: #502

Info I included in those PRs:

Created two pull requests (one on dataflow, the other on local deployer), these are for github issue #369 "Add debug capabilities to LocalAppDeployer".

With these two in place you can turn on debug by specifying "module.foo.debug-port=8800" as a deployment property.

The first pull request (on the deployer) recognizes a debug-port property and uses it to add a debug agent to the configuration for the Process it launches.

The second pull request (on dataflow) recognizes the deployment pattern module..debug-port=XXX and maps that to the debug-port property in the deployer.

This works but are the properties in the right place? Is it ok to have this as a deployment config property? (It is quite nice that turning debug on/off does not require meddling with the stream definition). What do we do for other deployers? Do we need a simpler 'debug=true/false' option alongside this for any that don't need a port, or do we need a deployer specific namespace subsection for this?

@sabbyanandan sabbyanandan modified the milestone: 1.0.0.M3 Apr 21, 2016
@sabbyanandan sabbyanandan mentioned this issue Apr 23, 2016
Closed
@sabbyanandan sabbyanandan added this to the 2.0.0.M1 milestone Nov 4, 2017
@jvmlet
Copy link

jvmlet commented Dec 4, 2017

Would be great to be able to debug the task launched by SCDF as well, see listen debugger mode approach described in SO

@sabbyanandan sabbyanandan mentioned this issue Jan 9, 2018
Closed
@sabbyanandan sabbyanandan removed this from the 2.0.0.M1 milestone Jan 29, 2018
@sabbyanandan
Copy link
Contributor

This was addressed in spring-cloud/spring-cloud-deployer-local#85; docs here.

corneil pushed a commit that referenced this issue Mar 23, 2023
@jvalkeal
Implement better help command feature
67f6837 
- Tweak all ApplicationRunner's to understand that when user wants
  to print help, we get same output with various options like
  -h, -help, --help, help.
- Also change connection init so that if help is requests, we
  don't try to connect to a server by changing target. This
  removes error if shell is just about to print help.
- We print static usage text and actual shell help command.
- All these happen if commands are run within OS shell,
  there's no changes when actual shell instance is launched.
- Didn't add tests as we're still figuring out how proper
  e2e tests should get handled.
- Fixes #369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aclement aclement

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[For discussion] basic debug support for deployers aclement/spring-cloud-dataflow
4 participants
@aclement @ericbottard @sabbyanandan @jvmlet