TaskLauncherProperties not being mapped properly from platform account

[chrisjs]

While investigating spring-cloud/spring-cloud-deployer-kubernetes#398 (comment) it was found that properties set into the scdf configmap that should be populated into TaskLauncherProperties is not happening.

For example:

  cloud:
    dataflow:
      task:
        platform:
          kubernetes:
            accounts:
              dev:
                limits:
                    memory: 1024Mi
                    cpu: 1
                backoffLimit: 1

Likely this is due to the glue between SCDF and deployer, for example:

In SCDF KubernetesTaskPlatformFactory.createLauncher there is:

         KubernetesTaskLauncher kubernetesTaskLauncher = new KubernetesTaskLauncher(
				kubernetesProperties, kubernetesClient, containerFactory);

Yet on the deployer side, in KubernetesTaskLauncher that constructor would be:

       @Autowired
	public KubernetesTaskLauncher(KubernetesDeployerProperties properties,
			KubernetesClient client, ContainerFactory containerFactory) {
		this(properties, new KubernetesTaskLauncherProperties(), client, containerFactory);
	}

which creates a new KubernetesTaskLauncherProperties so calling taskLauncherProperties.getBackoffLimit(); in say for example KubernetesTaskLauncher.getBackoffLimit(..) is just going to return null...

[sabbyanandan]

@ilayaperumalg @cppwfs: This sounds problematic; is this still an issue?

[ilayaperumalg]

Yes, we need an explicit K8s task launcher properties extracted from the K8s platform account properties to be used in the K8s task launcher. Fixed via #4546