Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LB's not needed #4499

Closed
jvalkeal opened this issue May 3, 2021 · 0 comments · Fixed by #4541
Closed

Remove LB's not needed #4499

jvalkeal opened this issue May 3, 2021 · 0 comments · Fixed by #4541
Assignees
@tzolov
Labels
area/tests Belongs to tests
Milestone
2.8.0-RC1

Comments

@jvalkeal
Copy link
Collaborator

jvalkeal commented May 3, 2021

spring-cloud-dataflow/spring-cloud-dataflow-server/src/test/java/org/springframework/cloud/dataflow/integration/test/DataFlowIT.java

Line 821 in 9337fc0

propertiesBuilder.put("deployer.*.kubernetes.createLoadBalancer", "true"); // requires LoadBalancer support on the platform

This is somewhat hitting public ip quota on aws account for tests.
@jvalkeal jvalkeal added the area/tests Belongs to tests label May 3, 2021
@jvalkeal jvalkeal added this to the 2.8.0-RC1 milestone May 3, 2021
tzolov added a commit to tzolov/spring-cloud-dataflow that referenced this issue May 27, 2021
@tzolov
Enable K8s-LB only for externally accessible apps
1e9ecf7 
 - Replace the wildcard with an explicit list of apps to be configured with LB.
 - Ensure that all http source apps and apps that need to provide actuator/logfile access are configured with LB.

 Resolves spring-cloud#4499
@tzolov tzolov mentioned this issue May 27, 2021
Merged
jvalkeal pushed a commit that referenced this issue May 27, 2021
@tzolov @jvalkeal
Enable K8s-LB only for externally accessible apps
0fbda03 
 - Replace the wildcard with an explicit list of apps to be configured with LB.
 - Ensure that all http source apps and apps that need to provide actuator/logfile access are configured with LB.

 Resolves #4499
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tzolov tzolov

Labels
area/tests Belongs to tests
Projects
None yet
Milestone
2.8.0-RC1
Development

Successfully merging a pull request may close this issue.

Enable K8s-LB only for externally accessible apps tzolov/spring-cloud-dataflow
2 participants
@jvalkeal @tzolov