Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App list shows wrong version count if source/sink has same name #4570

Closed
jvalkeal opened this issue Jun 9, 2021 · 1 comment
Closed

App list shows wrong version count if source/sink has same name #4570

jvalkeal opened this issue Jun 9, 2021 · 1 comment
Assignees
Labels
type/bug Is a bug report
Milestone

Comments

@jvalkeal
Copy link
Collaborator

jvalkeal commented Jun 9, 2021

Register:

source.file=maven://org.springframework.cloud.stream.app:file-source-rabbit:3.0.1
source.file.metadata=maven://org.springframework.cloud.stream.app:file-source-rabbit:jar:metadata:3.0.1

sink.file=maven://org.springframework.cloud.stream.app:file-sink-rabbit:3.0.1
sink.file.metadata=maven://org.springframework.cloud.stream.app:file-sink-rabbit:jar:metadata:3.0.1

image

Register:

sink.file=maven://org.springframework.cloud.stream.app:file-sink-rabbit:3.0.0
sink.file.metadata=maven://org.springframework.cloud.stream.app:file-sink-rabbit:jar:metadata:3.0.0

image

@oodamien
Copy link
Member

To get the applications list, /apps?page=0&size=20&sort=name,ASC&defaultVersion=true is called.
The service returns all the default applications, the property versions contains all the available versions.

{
  "_embedded": {
    "appRegistrationResourceList": [
      {
        "name": "file",
        "type": "sink",
        "uri": "maven://org.springframework.cloud.stream.app:file-sink-rabbit:3.0.1",
        "version": "3.0.1",
        "defaultVersion": true,
        "versions": [
          "3.0.0",
          "3.0.1"
        ],
        "label": null,
        "_links": {
          "self": {
            "href": "http://localhost:4200/apps/sink/file/3.0.1"
          }
        }
      },
      {
        "name": "file",
        "type": "source",
        "uri": "maven://org.springframework.cloud.stream.app:file-source-rabbit:3.0.1",
        "version": "3.0.1",
        "defaultVersion": true,
        "versions": [
          "3.0.0",
          "3.0.1"
        ],
        "label": null,
        "_links": {
          "self": {
            "href": "http://localhost:4200/apps/source/file/3.0.1"
          }
        }
      }
    ]
  },
  "_links": {
    "self": {
      "href": "http://localhost:4200/apps?defaultVersion=true&page=0&size=20&sort=name,asc"
    }
  },
  "page": {
    "size": 20,
    "totalElements": 2,
    "totalPages": 1,
    "number": 0
  }
}

@jvalkeal jvalkeal transferred this issue from spring-cloud/spring-cloud-dataflow-ui Jun 10, 2021
@jvalkeal jvalkeal added this to the 2.8.1 milestone Jun 10, 2021
@jvalkeal jvalkeal added the type/bug Is a bug report label Jun 10, 2021
@jvalkeal jvalkeal self-assigned this Jun 10, 2021
jvalkeal added a commit to jvalkeal/spring-cloud-dataflow that referenced this issue Jun 10, 2021
- When building appRegistrationResourceList, do filtering per type so that
  sink and sources with same name gets accurate registered versions.
- Fixes spring-cloud#4570
@tzolov tzolov closed this as completed in 9a015c6 Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Is a bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants