Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove graph property from available CTR property list on task exec page #4582

Closed
cppwfs opened this issue Jun 1, 2021 · 4 comments
Closed

Remove graph property from available CTR property list on task exec page #4582

cppwfs opened this issue Jun 1, 2021 · 4 comments
Assignees
@oodamien
Milestone
2.8.1

Comments

@cppwfs
Copy link
Contributor

cppwfs commented Jun 1, 2021

image

As shown above user can update the graph that is launched via this property. This property should not be displayed, as this is handled by the SCDF definition itself.
@oodamien
Copy link
Member

oodamien commented Jun 2, 2021

The fields are populated by requesting /tasks/ctr/options.
Should we fix the rest endpoint or do an exception in the UI side and not display this field?

@jvalkeal
Copy link
Collaborator

I'll poke around server side and move issue there if needed.

@jvalkeal jvalkeal transferred this issue from spring-cloud/spring-cloud-dataflow-ui Jun 15, 2021
@jvalkeal jvalkeal added this to the 2.8.1 milestone Jun 15, 2021
@jvalkeal
Copy link
Collaborator

Two options:

  1. Move away from automatic metadata generation and craft those files manually by taking existing generated files as base and then remove options which we don't want to expose. Boot annotation processor was never designed for cases where we have options, which are there, but are "transitive", in terms of what's gets shown in UI.

  2. Separate ComposedTaskProperties into public and internal classes and then filter based on those as we expose options via controller.

As a side note, we can also clean ctr pom and remove spring-cloud-dataflow-apps-metadata-plugin and properties-maven-plugin as those really were used when image were build via maven(we use pack now).

@jvalkeal
Copy link
Collaborator

Option 3, try to see if our extension for app metadata "visible" options can be used for this.

jvalkeal added a commit to jvalkeal/spring-cloud-dataflow that referenced this issue Jun 15, 2021
@jvalkeal
Handle ctr metadata manually
bc16668 
- Essentially remove spring-boot-configuration-processor
  from ctr and take existing generated spring-configuration-metadata.json
  and put it in sources.
- Modify spring-configuration-metadata.json to remove graph property.
- Remove spring-cloud-dataflow-apps-metadata-plugin and properties-maven-plugin
  from ctr build as those not needed as paketo is already generating
  label.
- Fixes spring-cloud#4582
@jvalkeal jvalkeal mentioned this issue Jun 15, 2021
Closed
@cppwfs cppwfs closed this as completed in e5c95af Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oodamien oodamien

Labels
None yet
Projects
None yet
Milestone
2.8.1
Development

Successfully merging a pull request may close this issue.

Handle ctr metadata manually jvalkeal/spring-cloud-dataflow
3 participants
@jvalkeal @oodamien @cppwfs