Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter for task descriptions and dslText #5294

Closed
klopfdreh opened this issue Apr 12, 2023 · 7 comments
Closed

Filter for task descriptions and dslText #5294

klopfdreh opened this issue Apr 12, 2023 · 7 comments
Milestone

Comments

@klopfdreh
Copy link
Contributor

Problem description:

In the description we add important detailed explanations for our tasks. Sadly it is currently not possible to filter or search in this description.

image

Solution description:

  1. Extend the "/tasks/definitions" REST endpoint.

    • Query parameter search should be renamed to nameSearch
    • New parameter descriptionSearch should be added

    Each time one of the filter is changed all values are collected and send to the backend.

    Example:

    • You search for name foo the query is changed to /tasks/definitions?nameSearch=foo
    • You in addition search for description bar the query is changed to /tasks/definitions?nameSearch=foo&descriptionSearch=bar
  2. The UI needs to be changed and the filter icon should be added to the description column. Each time you apply a filter the query parameter should be applied as mentioned before.

@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Apr 12, 2023
@klopfdreh
Copy link
Contributor Author

klopfdreh commented May 15, 2023

Just wanted to follow up on this ticket. Are there any plans to implement this?

@markpollack
Copy link
Contributor

Sounds like a good feature - maybe including searching across the name as well - not sure when we could get to it, but would you be interested in making a contribution?

@markpollack markpollack added status/need-feedback Calling participant to provide feedback and removed status/need-triage Team needs to triage and take a first look labels May 16, 2023
@klopfdreh
Copy link
Contributor Author

Sure - I am going to have a look when I am able to provide it. It may take some time.

@github-actions github-actions bot added for/team-attention For team attention and removed status/need-feedback Calling participant to provide feedback labels May 16, 2023
@klopfdreh
Copy link
Contributor Author

klopfdreh commented May 16, 2023

Done - I create PRs.

Edit: It is a simple implementation that allows filtering for taskName / description / dslText.

@klopfdreh
Copy link
Contributor Author

Can you please down port it to 2.10.4? 😁

@onobc onobc removed the for/team-attention For team attention label May 16, 2023
@onobc onobc added this to the 2.11.0 milestone May 16, 2023
@klopfdreh klopfdreh changed the title Filter for task descriptions Filter for task descriptions and dslText May 17, 2023
onobc pushed a commit to onobc/spring-cloud-dataflow that referenced this issue May 17, 2023
@markpollack
Copy link
Contributor

closed via b49e466

@klopfdreh
Copy link
Contributor Author

@markpollack - the UI part still needs to be integrated, otherwise no one is able to take a benefit from the backend changes 😁 (spring-cloud/spring-cloud-dataflow-ui#1921)

@onobc onobc modified the milestones: 2.11.0, 2.11.0-RC1 Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants