Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to the spring-cloud-dataflow-aggregate-task module #5446

Closed
onobc opened this issue Aug 30, 2023 · 2 comments · Fixed by #5460
Closed

Add tests to the spring-cloud-dataflow-aggregate-task module #5446

onobc opened this issue Aug 30, 2023 · 2 comments · Fixed by #5460
Assignees
@onobc
Milestone
2.11.0

Comments

@onobc
Copy link
Contributor

onobc commented Aug 30, 2023

We need to add tests as there are none in place in the newly added module spring-cloud-dataflow-aggregate-task.
@onobc onobc added this to the 2.11.0 milestone Aug 30, 2023
@onobc onobc mentioned this issue Aug 30, 2023
Closed
@corneil
Copy link
Contributor

corneil commented Aug 31, 2023

The tests for this is part of spring-cloud-dataflow-server-core since some of the components needed are added by the consumer of this module.

@onobc
Copy link
Contributor Author

onobc commented Aug 31, 2023

Got it. Let's add this to a README.md in this module or put a placeholder test that simply says "See xyz for tests".

@onobc onobc self-assigned this Aug 31, 2023
cppwfs added a commit to cppwfs/spring-cloud-dataflow that referenced this issue Sep 12, 2023
@cppwfs
Readme describes the spr-cloud-dataflow-aggregate-task module
22a696c 
Section also discusses where to find tests
resolves spring-cloud#5446
@cppwfs cppwfs mentioned this issue Sep 12, 2023
Merged
onobc pushed a commit that referenced this issue Sep 12, 2023
@cppwfs
Readme describes the spr-cloud-dataflow-aggregate-task module (#5460)
4af55b6 
Section also discusses where to find tests
resolves #5446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onobc onobc

Labels
None yet
Projects
None yet
Milestone
2.11.0
Development

Successfully merging a pull request may close this issue.

Readme describes the spr-cloud-dataflow-aggregate-task module cppwfs/spring-cloud-dataflow
2 participants
@corneil @onobc