Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TaskOperations launch API is not backwards compatible #5492

Closed
onobc opened this issue Oct 4, 2023 · 2 comments
Closed

TaskOperations launch API is not backwards compatible #5492

onobc opened this issue Oct 4, 2023 · 2 comments
Assignees
@corneil
Milestone
2.11.1

Comments

@onobc
Copy link
Contributor

onobc commented Oct 4, 2023

Currently the TaskOperations has a single launch API that calls to the (new in 2.11) task/executions/launch which ultimately implies you must be running SCDF 2.11.x.

As such, users can not use a 2.11 client (TaskOperations.launch) against a 2.10 server.

See sample changes in https://github.com/spring-cloud/spring-cloud-dataflow/compare/main...onobc:spring-cloud-dataflow:cbono-WIP-tasklaunch?expand=1

IMPORTANT: Also, are there any other APIs that have the same problem?
@onobc onobc added this to the 2.11.1 milestone Oct 4, 2023
@cppwfs
Copy link
Contributor

cppwfs commented Oct 4, 2023

We can use the dataFlowServerVersion in the TaskTemplate to determine which API call to use.

@corneil corneil mentioned this issue Oct 5, 2023
Merged
corneil added a commit that referenced this issue Oct 5, 2023
@corneil
Update TaskTemplate.launch to provide backwards compatible behaviour …
ea0157a 
…for old client. #5492
corneil added a commit that referenced this issue Oct 5, 2023
@corneil
Update Server version check to use about. #5492
1b3dcb5
@onobc
Copy link
Contributor Author

onobc commented Oct 12, 2023

Closed via ea0157a

@onobc onobc closed this as completed Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corneil corneil

Labels
None yet
Projects
None yet
Milestone
2.11.1
Development

No branches or pull requests
3 participants
@corneil @cppwfs @onobc