New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-824 Add Spring Restdocs Infrastructure #833
Conversation
|
||
[partintro] | ||
-- | ||
In this section you will learn all about Spring Cloud Data Flows REST API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spring Cloud Data Flows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moreover, and this goes beyond this simple PR, we should settle on Data Flow (here) or Dataflow (line 15), but not both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be "Data Flow"
...and rather than adding an apostrophe above to make it possessive, it might be better to say:
all about the Spring Cloud Data Flow REST API.
Overall, looks good, but I think it would be way more manageable if the tests were part of the |
Refactored the infrastructure so that the Rest Docs tests use a "representative" SCDF server instance. Also added more documentation. Should probably move the |
*/ | ||
public class AppRegistryDocumentation extends BaseDocumentation { | ||
|
||
@ClassRule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can move up
Moved everything over to the |
Awesome! |
*/ | ||
public class ApiDocumentation extends BaseDocumentation { | ||
|
||
@ClassRule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these can move up to the BaseDocumentation class
Squashed and merged as e5db3d9 with some additional cleanup |
Resolves #824
Resolves #821