Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployer should use Fabric8's Container validations #356

Open
cppwfs opened this issue Dec 16, 2019 · 0 comments
Open

Deployer should use Fabric8's Container validations #356

cppwfs opened this issue Dec 16, 2019 · 0 comments
Labels
type/technical-debt Techical Dept

Comments

@cppwfs
Copy link
Contributor

cppwfs commented Dec 16, 2019

Fabric8 Container class currently has constraints enumerated for its attributes.
i.e. for valid schedule name expression and maximum length.
We need to capture these ConstraintValidationExceptions when thrown, and wrap them with a meaningful message.
Currently we explicitly check for these in the validateScheduleName method, which seems forced.
Currently the hibernate validator in unit tests doesn't check the constraints enumerated in the Container class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/technical-debt Techical Dept
Projects
None yet
Development

No branches or pull requests

1 participant