Meaningful message returned if schedule name too long #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cppwfs
changed the title
chrisjs
reviewed
Dec 13, 2019
| @@ -190,4 +210,12 @@ private void setImagePullSecret(ScheduleRequest scheduleRequest, CronJob cronJob | |||
| .add(localObjectReference); | |||
| } | |||
| } | |||
|
|
|||
| private boolean isScheduleNameTooLong(String message ) { | |||
There was a problem hiding this comment.
maybe validationScheduleNameLength or similar -- mainly to match something liek the other validateScheduleName
|
|
||
| private boolean isScheduleNameTooLong(String message ) { | ||
| boolean result = false; | ||
| if(StringUtils.hasText(message) && message.contains("must be no more than") && message.endsWith("characters")) { |
|
Submitted issue #356 so that we can investigate using the Constraints provided by Fabric8 instead of home-rolling our own. |
|
merged in 034f9c4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #353