Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom name of volumeClaimTemplates for statefulSet deployments #418

Closed
chringwer opened this issue Feb 18, 2021 · 0 comments · Fixed by #447
Closed

Support custom name of volumeClaimTemplates for statefulSet deployments #418

chringwer opened this issue Feb 18, 2021 · 0 comments · Fixed by #447
Assignees
Labels
status/need-triage Team needs to triage and take a first look
Milestone

Comments

@chringwer
Copy link

While we have deployment properties to specify size and class of the volumeClaimTemplate for a stateful set (statefulSet.volumeClaimTemplate.storageClassName and statefulSet.volumeClaimTemplate.storage), there doesn't seem to be a way to specify the template's name. Instead it is hardcoded to be the appId.

Now, in order to really make use of the persistent storage, we would need to add a volumeMount referencing the template by name. When deploying via Spring Cloud Dataflow, I have not been able to figure out a way to predictably infer the appId upfront. Am I missing something?

I would like to suggest something like statefulSet.volumeClaimTemplate.name so that we have a way to deterministically reference it in a volumeMount.

@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Feb 18, 2021
@ilayaperumalg ilayaperumalg added this to the 2.6.0-M1 milestone May 12, 2021
@jvalkeal jvalkeal modified the milestones: 2.6.0-M1, 2.6.0-RC1 May 14, 2021
ilayaperumalg added a commit to ilayaperumalg/spring-cloud-deployer-kubernetes that referenced this issue May 21, 2021
ilayaperumalg added a commit to ilayaperumalg/spring-cloud-deployer-kubernetes that referenced this issue May 21, 2021
@tzolov tzolov closed this as completed in 1505ca7 May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/need-triage Team needs to triage and take a first look
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants