-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No pod annotations can be added to a scheduled task #445
Comments
This is a new feature and we'll have this addressed in the upcoming release. |
- Add support to add labels as well as pod annotations to the underlying pod template spec metadata - Add tests Resolves spring-cloud#445 Resolves spring-cloud#425
- Add support to add labels as well as pod annotations to the underlying pod template spec metadata - Add tests Resolves spring-cloud#445 Resolves spring-cloud#425
- Add support to add labels as well as pod annotations to the underlying pod template spec metadata - Add tests Resolves spring-cloud#445 Resolves spring-cloud#425
Thanks a lot for fixing this issue ! |
@zgassmann Would you mind giving this a try on the 2.8.0-SNAPSHOT version of SCDF server? We plan to do the release early next month and it would be nice to get your feedback before. Thanks! |
@ilayaperumalg, yes we would like to test it. At moment we are deploying with helm files using: server: image: How is the best way to test the 2.8.0-SNAPSHOT deploying with helm files in kubernetes ? Is there a repository I can reference ? Thanks ! |
Bitnami chart for 2.8.0 would be available only after we do the release of the same. So, you may want to try using the image from here |
@ilayaperumalg, thanks you, In the config map we have the data source defined, but it is not picked up in the new deployed version: spring: Something has changed for that since 2.7.1 ? |
Are you building locally? If so you will need to create your image using packeto. Installation instructions are here: https://paketo.io/docs/
|
Hi @cppwfs, thank you for your answer. No, I am not building locally, I just referenced the snapshot image in our helm files:
instead of repository: bitnami/spring-cloud-dataflow The server is starting up. The difference to the 2.7 version is that it is using H2 instead of PostgreSQL. I left our helm files the same (despite the image reference) including the datasource definition. Maybe I need to change the helm files for the 2.8 version so that the PostgreSQL datasource is used? |
@ilayaperumalg, meanwhile I deployed the 2.8.0-SNAPSHOT version in our kubernetes cluster |
@zgassmann Thank you for confirming! |
Hi @ilayaperumalg, I have another question about the scheduling. |
In this case SCDF, creates a cronjob for each schedule that is created. When you register a new version of the application, you will need to delete the schedule and recreate it, so that a new cronjob will be created using the new image. |
When launching a task from the GUI the pod gets the jobAnnotations defined either in the deployment properties or in the default task.platform.kubernetes.accounts.jobAnnotations.
When scheduling the task, the cronjob gets the jobAnnotations but not the pod of the task.
How can we add pod annotations to a scheduled task ?
The text was updated successfully, but these errors were encountered: