Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to resolve artifacts from private docker registry #74

Open
sabbyanandan opened this issue Aug 14, 2017 · 2 comments
Open

Add support to resolve artifacts from private docker registry #74

sabbyanandan opened this issue Aug 14, 2017 · 2 comments
Assignees

Comments

@sabbyanandan
Copy link
Contributor

As a user, I'd like to resolve artifacts from a private Docker registry.

Notes:

@sabbyanandan sabbyanandan added this to the 1.3.0.M1 milestone Aug 28, 2017
@ericbottard
Copy link
Contributor

Given that The local deployer uses the regular docker command, I believe there is nothing that can/should be done for this to work.
If the user has successfully authenticated against said repository (using docker login my.jfrog.io) then everything should just work.

Background reading: https://docs.docker.com/registry/deploying/

@ericbottard
Copy link
Contributor

Note that the format of authentication for the particular repository may be a bit peculiar, which may explain issues the original user may have.
For example, reading the doc about bintray: https://bintray.com/docs/usermanual/formats/formats_dockerrepositories.html

But again, I believe there is nothing we have to do at the SCDF level. All matters of authentication (even k8s pullSecret, which have nothing to do here) require that authentication is first done locally in docker. Once this is done, then things should "just work" given we're using the docker client

@ericbottard ericbottard self-assigned this Aug 31, 2017
@sabbyanandan sabbyanandan removed this from the 1.3.0.M1 milestone Sep 13, 2017
@markpollack markpollack added this to the 1.3.9.RELEASE milestone Sep 11, 2018
@sabbyanandan sabbyanandan removed this from the 1.3.10.RELEASE milestone Nov 15, 2018
@chrisjs chrisjs removed their assignment Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants