-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more filters #10
Comments
See 0105e57 for sample token-bucket filter. |
I'm working with Rate limiters too via filters. I really want to have the 3 prong approach we see here: https://stripe.com/blog/rate-limiters working with a Spring Cloud project. |
I'll take a look |
Nice, lots of code too! |
@checketts check out 34e6366. |
Wow that looks very clean with good potential for extensibility eventually. The Lua part scares me a bit since I don't understand how that integrates or changes the atomicity of the redis call. I've been trying to reason through a non-redis implementation, likely Memcached. Would porting the Lua code into Java client code be sufficient? |
https://redis.io/commands/eval#atomicity-of-scripts I like that this is run in production at stripe. |
Looking to migrate off our commercial gateway (CA). Main features we use today are for SOAP services would there be anything to re-implement those:
We use SpringWS but these were not extensively supported but possible in the WSS4j side. Looking if it's an easy switch over to CXF (3.2) that supports Spring Boot. |
I have a concurrent request rate limiter implemented on Redis using the same model as RedisRateLimiter and the Stripe rate limiters. Before I spend time prepping the code for a pull request, I'd like to know if there is interest? Thanks |
@sbartram if you're talking about the "Concurrent Request Rate Limiter" from https://stripe.com/blog/rate-limiters, then yes, there is interest. |
I'm working on filters that rewrite request/response body. Now they successfully work with string body, url encoded, json objects. In plans to add support of multipart/form-data and sse post-processing to complete the set of data conversions how it has been done in Spring Webflux handlers concerning codecs and readers/writers. See comment. Have you interest? |
@re6exp yes, PRs welcome |
i also want to rewrite request/response body, hold can pr to spring-cloud-gateway . |
@spencergibb |
@re6exp wow, that is major complex. I hope that is not what is ultimately needed. If it is, it will be a separate optional module. |
Hi All, Is Request Size limiting is available ? |
How about Set Response Content filter? I would love to see it on the list. |
@spencergibb @domainname |
Closing. Let's track filters individually now. Please open new issues. |
Includes GatewayRSocketProperties. Moves GatewayRSocketServer to a top level class that is a SmartLifeCycle. Also adds integration tests. fixes gh-10
Set Request HeaderLoadBalancerClient
)Spring RetrySimian Army Filters (latency, random text, bandwidth limits)Simian Army Filters (latency, random responses, bandwidth limits) #64The text was updated successfully, but these errors were encountered: