Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more filters #10

Closed
12 of 22 tasks
spencergibb opened this issue Jan 14, 2017 · 19 comments
Closed
12 of 22 tasks

Add more filters #10

spencergibb opened this issue Jan 14, 2017 · 19 comments

Comments

@spencergibb
Copy link
Member

spencergibb commented Jan 14, 2017

@spencergibb
Copy link
Member Author

See 0105e57 for sample token-bucket filter.

@checketts
Copy link

I'm working with Rate limiters too via filters. I really want to have the 3 prong approach we see here: https://stripe.com/blog/rate-limiters working with a Spring Cloud project.

@spencergibb
Copy link
Member Author

I'll take a look

@spencergibb
Copy link
Member Author

Nice, lots of code too!

spencergibb added a commit that referenced this issue Apr 15, 2017
@spencergibb
Copy link
Member Author

@checketts check out 34e6366.

@checketts
Copy link

Wow that looks very clean with good potential for extensibility eventually. The Lua part scares me a bit since I don't understand how that integrates or changes the atomicity of the redis call.

I've been trying to reason through a non-redis implementation, likely Memcached. Would porting the Lua code into Java client code be sufficient?

@spencergibb
Copy link
Member Author

https://redis.io/commands/eval#atomicity-of-scripts

I like that this is run in production at stripe.

@mdiskin
Copy link

mdiskin commented Jul 3, 2017

Looking to migrate off our commercial gateway (CA). Main features we use today are for SOAP services would there be anything to re-implement those:

  • Require/Add WS-Security Signature, Signed Timestamp/Element
  • Evalute XPATH, XSLT
  • Protect against Message Reply

We use SpringWS but these were not extensively supported but possible in the WSS4j side. Looking if it's an easy switch over to CXF (3.2) that supports Spring Boot.

@sbartram
Copy link

I have a concurrent request rate limiter implemented on Redis using the same model as RedisRateLimiter and the Stripe rate limiters. Before I spend time prepping the code for a pull request, I'd like to know if there is interest?

Thanks

@spencergibb
Copy link
Member Author

@sbartram if you're talking about the "Concurrent Request Rate Limiter" from https://stripe.com/blog/rate-limiters, then yes, there is interest.

@re6exp
Copy link
Contributor

re6exp commented Mar 29, 2018

I'm working on filters that rewrite request/response body.

Now they successfully work with string body, url encoded, json objects.

In plans to add support of multipart/form-data and sse post-processing to complete the set of data conversions how it has been done in Spring Webflux handlers concerning codecs and readers/writers.

See comment.

Have you interest?

@spencergibb
Copy link
Member Author

@re6exp yes, PRs welcome

@dragontree101
Copy link

i also want to rewrite request/response body, hold can pr to spring-cloud-gateway .
thanks

@re6exp
Copy link
Contributor

re6exp commented Apr 4, 2018

@spencergibb
Ok, after I will finish text-stream-based response rewritting, I'm going to prepare code to PR and release it. At the moment I have to deepen my Flux knowledge to solve it - I'm being in reading docs... After this, the form-multipart rewritting remains, I hope I will also do it. The progress can be viewed here. Any comments or suggestions are welcome.

@spencergibb
Copy link
Member Author

@re6exp wow, that is major complex. I hope that is not what is ultimately needed. If it is, it will be a separate optional module.

@ninja-panda
Copy link
Contributor

Hi All, Is Request Size limiting is available ?

@domainname
Copy link

How about Set Response Content filter? I would love to see it on the list.

@re6exp
Copy link
Contributor

re6exp commented Jun 9, 2018

@spencergibb @domainname
Here are some blocked changes that can be useful.

@spencergibb
Copy link
Member Author

Closing. Let's track filters individually now. Please open new issues.

spencergibb added a commit that referenced this issue Feb 22, 2019
Includes GatewayRSocketProperties. Moves GatewayRSocketServer to a top
level class that is a SmartLifeCycle. Also adds integration tests.

fixes gh-10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants