Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Hystrix command configuration #291

Closed
fitzoh opened this issue Apr 22, 2018 · 0 comments
Closed

Document Hystrix command configuration #291

fitzoh opened this issue Apr 22, 2018 · 0 comments

Comments

@fitzoh
Copy link
Contributor

fitzoh commented Apr 22, 2018

The current HystrixGatewayFilterFactory documentation shows how to configure a fallback URL, but doesn't touch on any of the other hystrix configuration options which are available (setting a timeout is what I was personally looking for).

The documentation should be updated to note how the HystrixGatewayFilterFactory.Config.name maps to a HystrixCommandKey, and explain how that integrates with Hystrix configuration.

It would also be nice to include an example or two. I suspect that setting a timeout will be the most commonly used configuration option, and is the only one I could find an example of in the tests.

hystrix.command.successcmd.execution.isolation.thread.timeoutInMilliseconds: 5000

Getting a bit off topic, but if that suspicion is correct, it might make sense to add some sugar around timeouts and make that a first class part of the DSL.

@fitzoh fitzoh mentioned this issue Apr 24, 2018
fitzoh added a commit to fitzoh/spring-cloud-gateway that referenced this issue Apr 30, 2018
@ryanjbaxter ryanjbaxter added this to the 2.0.0.RELEASE milestone Apr 30, 2018
ryanjbaxter added a commit that referenced this issue Apr 30, 2018
Add additional Hystrix documentation. Covers part of #288, fixes #291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants