New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Hystrix command configuration #291
Labels
Milestone
Comments
Closed
fitzoh
added a commit
to fitzoh/spring-cloud-gateway
that referenced
this issue
Apr 24, 2018
fitzoh
added a commit
to fitzoh/spring-cloud-gateway
that referenced
this issue
Apr 24, 2018
fitzoh
added a commit
to fitzoh/spring-cloud-gateway
that referenced
this issue
Apr 24, 2018
fitzoh
added a commit
to fitzoh/spring-cloud-gateway
that referenced
this issue
Apr 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current HystrixGatewayFilterFactory documentation shows how to configure a fallback URL, but doesn't touch on any of the other hystrix configuration options which are available (setting a timeout is what I was personally looking for).
The documentation should be updated to note how the
HystrixGatewayFilterFactory.Config.name
maps to aHystrixCommandKey
, and explain how that integrates with Hystrix configuration.It would also be nice to include an example or two. I suspect that setting a timeout will be the most commonly used configuration option, and is the only one I could find an example of in the tests.
spring-cloud-gateway/spring-cloud-gateway-core/src/test/resources/application.yml
Line 256 in 61badf8
Getting a bit off topic, but if that suspicion is correct, it might make sense to add some sugar around timeouts and make that a first class part of the DSL.
The text was updated successfully, but these errors were encountered: