Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to trip the circuit breaker based on returned status code #1836

Merged

Conversation

ryanjbaxter
Copy link
Contributor

In some cases you might want to trip a circuit breaker based on the status code returned from the downstream service. This provides a way to set a list of status codes to do this.

@ryanjbaxter ryanjbaxter added this to the 2.2.4.RELEASE milestone Jul 14, 2020
@ryanjbaxter ryanjbaxter added this to In progress in 2020.0.0-M3 via automation Jul 14, 2020
@ryanjbaxter ryanjbaxter added this to In progress in Hoxton.SR7 via automation Jul 14, 2020
@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #1836 into 2.2.x will increase coverage by 0.07%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##              2.2.x    #1836      +/-   ##
============================================
+ Coverage     74.49%   74.57%   +0.07%     
- Complexity     1280     1283       +3     
============================================
  Files           168      168              
  Lines          5473     5494      +21     
  Branches        420      421       +1     
============================================
+ Hits           4077     4097      +20     
- Misses         1179     1180       +1     
  Partials        217      217              
Impacted Files Coverage Δ Complexity Δ
...actory/SpringCloudCircuitBreakerFilterFactory.java 92.42% <85.00%> (-3.33%) 8.00 <1.00> (+1.00) ⬇️
...eway/filter/factory/RetryGatewayFilterFactory.java 77.71% <100.00%> (-0.50%) 36.00 <1.00> (-1.00)
.../cloud/gateway/support/ServerWebExchangeUtils.java 88.59% <100.00%> (+0.63%) 31.00 <2.00> (+2.00)
...cloud/gateway/filter/NettyWriteResponseFilter.java 80.85% <0.00%> (+4.25%) 16.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d165617...ef32cb7. Read the comment docs.

Copy link
Member

@spencergibb spencergibb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change, after that, LGTM

@ryanjbaxter ryanjbaxter merged commit 5bd5791 into spring-cloud:2.2.x Jul 21, 2020
Hoxton.SR7 automation moved this from In progress to Done Jul 21, 2020
2020.0.0-M3 automation moved this from In progress to Done Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2020.0.0-M3
  
Done
Hoxton.SR7
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants