Fix PrematureCloseException by adding check for connection and channel before dispose #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ureCloseException
This was referenced Dec 29, 2020
Closed
ctlove0523
approved these changes
Jan 1, 2021
|
@violetagg, @bsideup or @OlegDokuka do you see any issues with this? |
|
LGTM. But better to ask @violetagg |
|
LGTM |
|
Hi @spencergibb @OlegDokuka in zuul we have zuul.host.socket-timeout-millis, do we have any equivalent in spring cloud gateway ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add channel check before dispose which may cause reactor-netty PrematureCloseException.
Test case:
1、We are doing a perfomance test using Spring Cloud Gateway v2.2.5.RELEASE
2、The request is HTTP POST which body size is less than 1k Bytes
3、The backend service return a response 200 OK as a result
Bug description:
Exception appears in spring cloud gateway in Very Small Probability as below:
reactor.netty.http.client.PrematureCloseException: Connection has been closed BEFORE response, while sending request body
In nearly 500,000 http post request tests, there will be dozens of errors.
When applied this fix, retested with nearly 3, 000,000 requests, No error occurred.
Related issue:
SCG:
Connection prematurely closed BEFORE response