Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note to discover location documentation about spring cloud load balancer #3348

Merged

Conversation

wind57
Copy link
Contributor

@wind57 wind57 commented Apr 10, 2024

No description provided.

@wind57
Copy link
Contributor Author

wind57 commented Apr 10, 2024

@ryanjbaxter needs approval...

@@ -3,7 +3,9 @@

You can configure the gateway to create routes based on services registered with a `DiscoveryClient` compatible service registry.

To enable this, set `spring.cloud.gateway.discovery.locator.enabled=true` and make sure a `DiscoveryClient` implementation (such as Netflix Eureka, Consul, or Zookeeper) is on the classpath and enabled.
The routes created use the protocol `lb://service-name` (where `service-name` is the String that `DsicoveryClient::getServices` will return) and this means that they are load-balanced. For that reason, you also need to include the `org.springframework.cloud:spring-cloud-starter-loadbalancer` dependency, so that it is available on the classpath.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would include say "By default the routes created..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, needs one more time, I had a typo there

@spencergibb spencergibb changed the title add documentation add note to discover location documentation about spring cloud load balancer Apr 10, 2024
@ryanjbaxter ryanjbaxter added this to the 4.1.3 milestone Apr 10, 2024
@ryanjbaxter ryanjbaxter merged commit 66aa480 into spring-cloud:main Apr 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants